openmrs.atlassian.net
Open in
urlscan Pro
185.166.143.38
Public Scan
Submitted URL: https://tickets.openmrs.org/browse/GCI-183
Effective URL: https://openmrs.atlassian.net/browse/GCI-183
Submission: On June 10 via api from US — Scanned from DE
Effective URL: https://openmrs.atlassian.net/browse/GCI-183
Submission: On June 10 via api from US — Scanned from DE
Form analysis 1 forms found in the DOM
<form id="jira_request_timing_info" class="dont-default-focus">
<fieldset class="parameters hidden">
<input type="hidden" title="jira.request.trace.id" value="92f468aea4c349189cb8887ecd9b8eaa">
<input type="hidden" title="jira.request.sampled" value="false">
<input type="hidden" title="jira.request.start.millis" value="1718015774737">
<input type="hidden" title="jira.request.server.time" value="522">
<input type="hidden" title="jira.request.server.head.time" value="45">
<input type="hidden" title="jira.request.id" value="41bd6c183825fac20e3c1382c6b39cd3">
<input type="hidden" title="jira.session.expiry.time" value="-">
<input type="hidden" title="jira.session.expiry.in.mins" value="-">
<input id="jiraConcurrentRequests" type="hidden" name="jira.request.concurrent.requests" value="5">
</fieldset>
</form>Text Content
Skip to: 1. Skip to: Skip to Jira NavigationSkip to Jira Navigation 2. Skip to: Skip to Side NavigationSkip to Side Navigation 3. Skip to: Skip to Main ContentSkip to Main Content Welcome to our new JIRA instance! We migrated all OpenMRS ID accounts and issues to this new cloud instance. Please use your_openmrsid@id.openmrs.org as your e-mail to sign in. OpenMRS Issues Projects Filters Dashboards Apps Create GOOGLE CODE-IN Software project Menu Reports Issues Components You're in a company-managed project Projects Google Code-in GCI-183 INTRODUCE A NEW VARIABLE INSTEAD OF REUSING THE PARAMETER "FILENAME". Create DESCRIPTION Replace this line https://github.com/openmrs/openmrs-core/blob/master/web/src/main/java/org/openmrs/web/filter/util/CustomResourceLoader.java#L95 by assigning to a temporary variable instead of the passed in parameter. Background Information: Method parameters, caught exceptions and foreach variables should not be reassigned While it is technically correct to assign to parameters from within method bodies, it is better to use temporary variables to store intermediate results. This rule will typically detect cases where a constructor parameter is assigned to itself instead of a field of the same name, i.e. when this was forgotten. Allowing parameters to be assigned to also reduces the code readability as developers will not be able to know whether the original parameter or some temporary variable is being accessed without going through the whole method. Moreover, some developers might also expect assignments of method parameters to be visible from callers, which is not the case and can confuse them. All parameters should be treated as final. ACTIVITY Show: AllCommentsHistoryWork log Newest first DANIEL KAYIWA DECEMBER 10, 2017 AT 8:56 AM Merged at https://github.com/openmrs/openmrs-core/commit/cb5e23a932b4566228bfd5928b64081b00b161f6 Thanks Shivansh DANIEL KAYIWA DECEMBER 8, 2017 AT 12:20 AM Added comments to address on github. YUSUF KARIM DECEMBER 5, 2017 AT 4:15 AM Left comments on the PR @Shivansh Sharma SHIVANSH SHARMA DECEMBER 4, 2017 AT 7:18 PM EDITED Link to Pull Request : https://github.com/openmrs/openmrs-core/pull/2429 Give feedback Closed Fixed Actions Pinned fields Click on the next to a field label to start pinning. Details ASSIGNEE Shivansh Sharma REPORTER Daniel Kayiwa LABELS beginnercodingcuratedgci2017intro COMPLEXITY Low TIME TRACKING 1d logged PRIORITY Should Created October 30, 2017 at 5:48 AM Updated December 10, 2017 at 8:56 AM Resolved December 10, 2017 at 8:56 AM Configure FLAG NOTIFICATIONS Something's gone wrong Looks like you've been signed out. Try logging in again. Log in